Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Feat #81: Added index support #82

Merged
merged 2 commits into from
Nov 19, 2021
Merged

Feat #81: Added index support #82

merged 2 commits into from
Nov 19, 2021

Conversation

0xrushi
Copy link
Contributor

@0xrushi 0xrushi commented Oct 29, 2021

keep run list

image

keep run 1

image

@pep8speaks
Copy link

pep8speaks commented Oct 29, 2021 •
edited
Loading

Hello @rushic24! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-10-29 02:16:42 UTC

@OrkoHunter OrkoHunter linked an issue Nov 3, 2021 that may be closed by this pull request
Can we have an id generated by default? #81
Closed
OrkoHunter
OrkoHunter approved these changes Nov 19, 2021
View reviewed changes
Copy link
Owner

@OrkoHunter OrkoHunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat ! Thank you for adding this 🎉

@OrkoHunter OrkoHunter merged commit 3c95c4c into OrkoHunter:master Nov 19, 2021
@0xrushi
Copy link
Contributor Author

0xrushi commented Jun 19, 2022

@OrkoHunter I guess this was removed in later releases? Did it have any issue ?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@OrkoHunter OrkoHunter OrkoHunter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can we have an id generated by default?
3 participants
@0xrushi @pep8speaks @OrkoHunter