This repository has been archived by the owner on Jul 9, 2023. It is now read-only.
Fix for UpdateIAmAlive in CosmosDBMembershipTable.cs #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… passed in from Orleans only contained SiloAddress and IAmAliveTime. The code now reads the existing state from Cosmos Db, updates IAmAliveTime and writes it back. From what I can see, this is what UpdateIAmAlive.js used to do.
|
Apologies for not getting to this sooner, @NickBarrett! I was unable to push updates to your PR branch, so I pushed them to a new PR: #51 |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again folks,
We have been trying out Cosmos Db based clustering and came across issue 6987 already reported in the
dotnet/orleansrepo.On investigation, the issue is caused by Orleans passing a
MembershipEntrytoUpdateIAmAlivethat only has theSiloAddressandIAmAliveTimeproperties filed with data. After being converted to aSiloEntitybyConstructSiloEntityId, the save to Cosmos Db would fail due toStartTime(as well as the rest of the properties) just being their default values.This pr pulls the existing
SiloEntityfrom Cosmos Db, updates theIAmAliveTimeproperty and saves it back to Cosmos Db.From what we can tell, this is what used to happen in
UpdateIAmAlive.jsbefore it was removed.Cheers,
Nick