-
Notifications
You must be signed in to change notification settings - Fork 334
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ticket #102 - Fixed bug where filename would be [object HTMLDivElemen…
…t] if the element didnt have an ID and no file name was given. Also added unloads where applicable in the spec which sped up the tests.
- Loading branch information
1 parent
4e90fd4
commit 0aa0b7a
Showing
4 changed files
with
184 additions
and
42 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
0aa0b7a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnmdonahue @dadambickford - This commit should speed up all your guys' tests :D (hopefully anyway).
Also, could you guys see the notes I put in the
src/editor.js
file and let me know if it looks OK?0aa0b7a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comparing to master, it went from 18 seconds to 10 seconds. Hopefully you two see better results also.