Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Improve straight skeleton robustness #92

Closed
wants to merge 1 commit into from

Conversation

strk
Copy link

@strk strk commented Jun 17, 2015

This is done by shifting data near the origin
while computing the skeleton.

Fixes #89

This is done by shifting data near the origin
while computing the skeleton.

Fixes Oslandia#89
@strk
Copy link
Author

strk commented Jun 17, 2015

I'm looking at adding a testcase for this, meanwhile if you see an opportunity to avoid a copy, that'd be nice (but performance isn't bad as it is)

@strk
Copy link
Author

strk commented Jun 17, 2015

Writing the testcase I hit another bug, making "Covers" return true when instead should return false ...
See #93

@strk
Copy link
Author

strk commented Jun 17, 2015

So #93 was finally found to be an invalid bug. But I'm still having problems reproducing the robustness issue when reading the polygon from WKT, as it slightly moves vertices to not represent a problem anymore.

@Remi-C
Copy link

Remi-C commented Jun 17, 2015

If I remember well, WKT limits the precision.
WKB on the opposite is more precise (about 2 digits more).

Maybe you should test using wkb as input, and not wkt.

Cheers,
Rémi-C

2015-06-17 11:10 GMT+02:00 Sandro Santilli notifications@github.com:

So #93 #93 was finally found
to be an invalid bug. But I'm still having problems reproducing the
robustness issue when reading the polygon from WKT, as it slightly moves
vertices to not represent a problem anymore.


Reply to this email directly or view it on GitHub
#92 (comment).

@strk
Copy link
Author

strk commented Jun 17, 2015 via email

@vmora
Copy link
Contributor

vmora commented Jun 17, 2015

This may be worth an enhancement ticket

@strk
Copy link
Author

strk commented Jun 17, 2015 via email

@strk strk added this to the 1.2.0 milestone Jun 17, 2015
@strk
Copy link
Author

strk commented Jun 17, 2015

Pushed as c9e3cff -- testcase will need to wait (will file another ticket)

@strk strk closed this Jun 17, 2015
@strk strk deleted the shiftedStraightSkeleton branch June 17, 2015 14:12
danielcu888 added a commit to danielcu888/SFCGAL that referenced this pull request Jun 15, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants