-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
docs: improve api development setup doc #156
Conversation
Remove un-required line in introduction part Add command to install node 20 using nvm in prerequisites Add commands to check status of mariadb and redis services Update command when cloning repo to cd to the api folder Make some other formatting changes to document structure
WalkthroughThe recent update enhances the development setup documentation for an API project. It streamlines the process by updating Node.js installation instructions, refining repository cloning, and ensuring essential services like Redis and MariaDB are correctly checked. It also improves the initial configuration guidance and database setup clarity, alongside better instructions for booting up the development server. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- apps/api/docs/development-setup.md (3 hunks)
Additional comments: 6
apps/api/docs/development-setup.md (6)
- 10-10: Node.js version specified as v20.x or higher aligns with the PR objectives. Ensure that this version is supported by all dependencies.
- 21-24: Commands for checking the status of Redis and MariaDB services are clear and correctly formatted. Verify that these commands are universally applicable across different operating systems or add a note for OS-specific variations.
- 31-32: The repository name in the clone step has been updated correctly. Ensure the path
cd osmo-x/apps/api
accurately reflects the project's directory structure.- 90-90: Mentioning the use of
.env.example
for configuration is a good practice. Ensure that the.env.example
file is up-to-date with all necessary environment variables.- 96-102: Database setup steps are clarified with the inclusion of running migrations. Ensure the command
npm run typeorm:run-migration
is correctly named and functional.- 110-110: Instructions for starting the development server are improved. Confirm that
npm run start:dev
is the correct command and that it works as expected.
API PR Checklist
Pre-requisites
PR Details
PR details have been updated as per the given format (see below)
feat: add admin login endpoint
)Additional Information
ready for review
should be added if the PR is ready to be reviewed)Description:
This PR updates the API development setup documentation to add and improve missing/existing content in the document.
Related changes:
Mentioned in Documentation changes
Screenshots:
N/A
Query request and response:
N/A
Documentation changes:
Test suite output:
N/A
Pending actions:
N/A
Additional notes:
N/A
Summary by CodeRabbit