Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add test for different training times (:pull:1995 extra) #2013

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Add test for different training times (:pull:1995 extra) #2013

merged 4 commits into from
Dec 10, 2024

Conversation

coxipi
Copy link
Contributor

@coxipi coxipi commented Dec 9, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

*Just add a test for Sarah's hidden feature (ref and hist can have different times, which will not affect the computation of adjustment factors)

Does this PR introduce a breaking change?

Other information:

@github-actions github-actions bot added the sdba Issues concerning the sdba submodule. label Dec 9, 2024
@coxipi coxipi changed the title Add test for different training times (:pull:1995 extra) Add test for different training times (:pull:1995 extra) Dec 9, 2024
@github-actions github-actions bot added the approved Approved for additional tests label Dec 9, 2024
@coveralls
Copy link

Coverage Status

coverage: 89.343% (-0.03%) from 89.372%
when pulling 1b0b1d4 on check_matching_times
into 959308c on main.

@coxipi coxipi merged commit 127ba65 into main Dec 10, 2024
21 checks passed
@coxipi coxipi deleted the check_matching_times branch December 10, 2024 01:05
@coxipi coxipi mentioned this pull request Dec 10, 2024
Closed
1 task
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests sdba Issues concerning the sdba submodule.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coxipi @coveralls @Zeitsperre