Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix naciscdn.org #212

Merged
merged 2 commits into from
Sep 7, 2021
Merged

fix naciscdn.org #212

merged 2 commits into from
Sep 7, 2021

Conversation

prih
Copy link
Contributor

@prih prih commented Sep 7, 2021

@Overv Overv merged commit 0a4d079 into Overv:master Sep 7, 2021
@Overv
Copy link
Owner

Overv commented Sep 7, 2021

Thanks for the fix! Fixes #211.

@endianjoakim
Copy link

I'm running v1.7.4 from Docker hub and I'm still getting

requests.exceptions.ConnectionError: HTTPSConnectionPool(host='naciscdn.org', port=443): Max retries exceeded with url: /naturalearth/110m/cultural/ne_110m_admin_0_boundary_lines_land.zip (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7fc7555f3220>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution'))

Was the correct dockerfile used to generate this image?

@Istador
Copy link
Contributor

Istador commented Sep 8, 2021

I'm running v1.7.4 from Docker hub and I'm still getting

[...]

Was the correct dockerfile used to generate this image?

Doesn't seem so.

According to hub.docker.com, the image layer 14 was build with the following command:
/bin/sh -c mkdir -p /home/renderer/src && cd /home/renderer/src && git clone --single-branch --branch v5.3.1 https://github.com/gravitystorm/openstreetmap-carto.git --depth 1 && cd openstreetmap-carto && rm -rf .git && npm install -g carto@0.18.2 && carto project.mml > mapnik.xml

So, the sed command is missing from

RUN mkdir -p /home/renderer/src \
&& cd /home/renderer/src \
&& git clone --single-branch --branch v5.3.1 https://github.com/gravitystorm/openstreetmap-carto.git --depth 1 \
&& cd openstreetmap-carto \
&& rm -rf .git \
&& sed -ie 's#https:\/\/naciscdn.org\/naturalearth\/110m\/cultural\/ne_110m_admin_0_boundary_lines_land.zip#https:\/\/naturalearth.s3.amazonaws.com\/110m_cultural\/ne_110m_admin_0_boundary_lines_land.zip#g' external-data.yml \
&& npm install -g carto@0.18.2 \
&& carto project.mml > mapnik.xml

@timothyosm timothyosm mentioned this pull request Sep 8, 2021
@Overv
Copy link
Owner

Overv commented Sep 8, 2021

Sorry, should be fixed now.

@timothyosm
Copy link

Using overv/openstreetmap-tile-server:v1.7.4 i still seem to be running into the same error. I

@Istador
Copy link
Contributor

Istador commented Sep 9, 2021

Using overv/openstreetmap-tile-server:v1.7.4 i still seem to be running into the same error. I

Because the existing tag was updated, make sure that you pull the updated version. Otherwise you still use the old version on your machine. By default docker only pulls images/tags it doesn't have locally and never updates them (by the way this also applies when you use latest, your local version might be years old depending on your last pull).

Update:

  • docker pull overv/openstreetmap-tile-server:v1.7.4
  • When using docker-compose you can alternatively just use docker-compose pull.
  • When you're building your own image based on it, you'll need to rebuild it with docker build or docker-compose build (build also comes with a --pull argument, to do both in one step).

Make sure that you use the new image:

  • When reusing containers with docker start / docker stop you'll need to rm the container and create a new one with docker run.
  • When you only use docker-compose stop, docker-compose start and docker-compose restart, you'll also need to recreate the container. Make sure to use docker-compose up -d (or docker-compose up --no-start) to recreate the container with the new local version that you pulled.

@timothyosm
Copy link

Thanks mate, that's a great explanation!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants