Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade versions #248

Merged
merged 4 commits into from
Mar 28, 2022
Merged

Upgrade versions #248

merged 4 commits into from
Mar 28, 2022

Conversation

galewis2
Copy link
Collaborator

@galewis2 galewis2 commented Feb 17, 2022

Upgrades PostGIS, Postgres, Leaflet, carto, openstreetmap-carto.

Test with:

sudo docker build -t test .
sudo docker run -e DOWNLOAD_PBF=https://download.geofabrik.de/europe/luxembourg-latest.osm.pbf -e DOWNLOAD_POLY=https://download.geofabrik.de/europe/luxembourg.poly -v openstreetmap-data:/var/lib/postgresql/14/main test import
sudo docker run -p 8080:80 -v openstreetmap-data:/var/lib/postgresql/14/main -d test run

@galewis2 galewis2 marked this pull request as draft February 17, 2022 14:11
@galewis2 galewis2 marked this pull request as ready for review February 17, 2022 18:59
@galewis2 galewis2 mentioned this pull request Feb 17, 2022
@galewis2 galewis2 merged commit f120371 into master Mar 28, 2022
@galewis2 galewis2 deleted the galewis2-upgrade branch March 28, 2022 13:12
@Istador
Copy link
Contributor

Istador commented Apr 2, 2022

Because this is a breaking change for users (they need to change their volume mount point and need to manually upgrade thir postgres database for existing volumes), please bump the major version number.

The next version should be 2.0.0.

@Istador
Copy link
Contributor

Istador commented Apr 7, 2022

Additional problem: This merged PR didn't made it to docker hub yet. Meaning the latest tag is still using postgres 12 and not 14. But the README.md documentation here on Github is already mentioning volume mounts for version 14. This confuses users.

See issue #259.

@Istador
Copy link
Contributor

Istador commented Apr 7, 2022

I'm also currently working on a solution for issue #257. I'll likely create a pull request for that soon (today or tomorrow).

(So you might want to wait with an official 2.0.0 release? Because otherwise that'd be another breaking change called 3.0.0 then?)

@nielsole
Copy link
Collaborator

nielsole commented Apr 9, 2022

bumped to 2.0.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants