cmec and tests directories are being included in python package

[xylar]

Because of this call to find_packages() without any arguments, I think you are picking up the cmec and tests directories within the python package.

pcmdi_metrics/setup.py

Line 65 in 2fd4d66

packages = find_packages()

Changing this call to:

packages = find_packages(include='src/python')

would likely avoid this, though I haven't tested it myself. (The lines immediately above this do nothing because packages is replaced on this line.)

Here is a screenshot from the latest tar file from conda-forge:

This is not a good situation because it is unclear if cmec is coming from its own conda-forge package (as it should be) or from this package (not desired).

[lee1043]

Hi @xylar, thank you for pointing this out. In PR #881, I am excluding cmec and tests directories from find_packages.

@acordonez I don't think there is any function that needs to be imported from under the cmec directory, could you please confirm on this?

@tomvothecoder I am excluding tests directory because I think it is yet in use. Do you think that is okay? I also wonder whether tests directory should be re-included when it will be used?

[acordonez]

@lee1043 nothing in the cmec folder needs to be included in the pcmdi_metrics package.

[xylar]

@lee1043, great, thank you!

[tomvothecoder]

@tomvothecoder I am excluding tests directory because I think it is yet in use. Do you think that is okay? I also wonder whether tests directory should be re-included when it will be used?

Hey Jiwoo, yes this should be okay. As far as I'm aware, it is standard Python practice to not include the tests directory in the package build. This directory is used to store tests that are ran locally or in CI/CD builds.

[lee1043]

@acordonez @tomvothecoder thank you for your comments!