Fix for 16 bit spec const values #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed CI script * Formatter config * Resolve warnings
|
Thank you for your constant help! I pushed a commit to add CI checks (which I forgot to clean up before) btw. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into two issues using
u16specialized constants:spirq::reflect_cfg::ReflectConfig::specialize()allows using two bytes to setup a typeless constant, butspq_core::constant::ConstantValue::to_typed()expected four-byteu32-encoded constantsAs far as the evaluator implementations, there are a bunch of missing cases (see #1). I think reorganizing them into something like
match (op, operands, result_ty) { ...might make the code easier to fill out and remove a bunch of duplicatedErrcases.