Respect all sniffs when reviewing PHP_CodeSniffer itself

[fredden]

Description

This is a re-creation of squizlabs/PHP_CodeSniffer#3914

While working on another task, I noticed that warnings are ignored by default. This seems unintentional. Some discussion regarding this has taken place in squizlabs/PHP_CodeSniffer#3914

Suggested changelog entry

Respect warnings as well as errors from sniffs within the coding standard for PHP_CodeSniffer itself.

Types of changes

• Bug fix (non-breaking change which fixes an issue)

PR checklist

• I have checked there is no other PR open for the same change.
• I have read the Contribution Guidelines.
• I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
• I have verified that the code complies with the projects coding standards.

[jrfnl]

@fredden Thanks for porting this over. In its current state (with only one remark), I'm okay to accept this.

Note: further changes to the ruleset used by PHPCS are not my current priority. If anything, I'll likely want to standardize on something closer to PHPCSDevCS at some point in the future.

[jrfnl]

I'd rather keep this at the correct tag (@link) than change it just to satisfy an outdated sniff. Could you please add an exception instead ?

[jrfnl]

P.S.: feel free to squash the commits to one commit when updating the PR.

[jrfnl]

Thanks @fredden !

FYI: I'm not adding a changelog entry as this is not a user-facing change.

[fredden]

If anything, I'll likely want to standardize on something closer to PHPCSDevCS at some point in the future.

I made a start on this. I got to the point where the standard is installed and runs successfully. The next step involves changing nearly every file in the repository. I've put it down for now. Would a draft pull request be valuable? I can trivially open this as a reminder / TODO item if you'd like.

[jrfnl]

If anything, I'll likely want to standardize on something closer to PHPCSDevCS at some point in the future.

I made a start on this. I got to the point where the standard is installed and runs successfully. The next step involves changing nearly every file in the repository. I've put it down for now. Would a draft pull request be valuable? I can trivially open this as a reminder / TODO item if you'd like.

Sorry, while I appreciate what you are trying to do, this is definitely not a priority at this moment and not something I want to spend time on at this time.

An open issue to discuss a plan to get there is one thing, an open PR, draft or not, will just be closed as noise at this time.

[fredden]

I agree regarding priorities. I know you have your own way of tracking backlog items; I trust that this is somewhere in that system.

For future reference, the work started here includes 09d13e3 and PHPCSStandards/composer-installer#215.

[jrfnl]

I agree regarding priorities. I know you have your own way of tracking backlog items; I trust that this is somewhere in that system.

I will be opening issues for most of those ideas/plans/backlog items, #105, #106, #120 and some older issues ported over from the Squizlabs repo are just the start of that, but 3.8.0 needs to get released first. The rest can wait and is just a distraction at this moment.