Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Documentation] PSR12 - Opening Brace Space #171

Conversation

dingo-d
Copy link
Contributor

@dingo-d dingo-d commented Dec 16, 2023

The PR contains the documentation for the PSR12/Classes/OpeningBraceSpace sniff.

Description

This PR will add the documentation for the above-mentioned sniff, according to the official standard definitions.

Suggested changelog entry

Add documentation for the PSR12 OpeningBraceSpace sniff

Related issues/external references

Part of #148

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dingo-d Thanks for writing this up. Looking good, Code comparisons, formatting etc, all good. Just two small remarks.

@jrfnl jrfnl added this to the 3.x Next milestone Dec 26, 2023
dingo-d and others added 2 commits December 26, 2023 10:22
Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
@dingo-d
Copy link
Contributor Author

dingo-d commented Jan 4, 2024

You can squash merge this one if it's ok 🙂

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Thanks @dingo-d !

@jrfnl jrfnl merged commit 269098e into PHPCSStandards:master Jan 4, 2024
38 checks passed
jrfnl pushed a commit that referenced this pull request Jan 4, 2024
* Add the documentation for the PSR12 Opening Brace Space sniff
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants