-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Documentation] PSR12 - Opening Brace Space #171
Merged
jrfnl
merged 4 commits into
PHPCSStandards:master
from
dingo-d:documentation/PSR12-classes-opening-brace-space
Jan 4, 2024
Merged
[Documentation] PSR12 - Opening Brace Space #171
jrfnl
merged 4 commits into
PHPCSStandards:master
from
dingo-d:documentation/PSR12-classes-opening-brace-space
Jan 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 tasks
jrfnl
requested changes
Dec 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dingo-d Thanks for writing this up. Looking good, Code comparisons, formatting etc, all good. Just two small remarks.
Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
jrfnl
reviewed
Jan 3, 2024
Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
You can squash merge this one if it's ok 🙂 |
jrfnl
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dingo-d !
jrfnl
pushed a commit
that referenced
this pull request
Jan 4, 2024
* Add the documentation for the PSR12 Opening Brace Space sniff
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR contains the documentation for the PSR12/Classes/OpeningBraceSpace sniff.
Description
This PR will add the documentation for the above-mentioned sniff, according to the official standard definitions.
Suggested changelog entry
Add documentation for the PSR12 OpeningBraceSpace sniff
Related issues/external references
Part of #148
Types of changes
PR checklist