File::getMethodProperties(): skip over closure use statements #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
changed the title
|
Hmm.. turns out the code sample which triggered me to look into this was actually a parse error 🤦🏻♀️. I do still believe the change has value, but I've updated the PR description to reflect the reality (and simplified the tests a little). |
jrfnl
force-pushed
the
feature/getmethodproperties-bugfix-skip-closure-use
branch
from
4343197
to
87fd6b8
Compare
This PR improves performance of the `File::getMethodProperties()` method and prevents incorrect return type information for closures `use` clauses containing invalid variable imports in the `use` clause (defensive coding). Closure `use` statements can only import plain variables, not properties or other more complex variables. As things were, when such "illegal" variables were imported in a closure `use`, the information for the return type could get mangled. While this would be a parse error, for the purposes of static analysis, the `File::getMethodProperties()` method should still handle this correctly. This commit updates the `File::getMethodProperties()` method to always skip over the complete `use` clause, which prevents the issue and improves performance as the same time (less token walking). Includes unit tests.
jrfnl
force-pushed
the
feature/getmethodproperties-bugfix-skip-closure-use
branch
from
87fd6b8
to
0dff1a5
Compare
|
Rebased without changes, merging once the build has passed. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves performance of the
File::getMethodProperties()method and prevents incorrect return type information for closureuseclauses containing invalid variable imports in theuseclause (defensive coding).Closure
usestatements can only import plain variables, not properties or other more complex variables.As things were, when such "illegal" variables were imported in a closure
use, the information for the return type could get mangled.While this would be a parse error, for the purposes of static analysis, the
File::getMethodProperties()method should still handle this correctly.This commit updates the
File::getMethodProperties()method to always skip over the completeuseclause, which prevents the issue and improves performance as the same time (less token walking).Includes unit tests.
Suggested changelog entry
File::getMethodProperties(): small performance improvement & more defensive coding