Skip to content

Fix transparent background images to be displayed correctly #2638

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Aug 15, 2024

Conversation

ElwynVdb
Copy link
Contributor

@ElwynVdb ElwynVdb commented Jul 30, 2024

Description

When inserting an image with an alpha channel and a transparent background into the Word document, the background was filled with white.

image

After the fix, the transparency is retained.

image

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

@coveralls
Copy link

coveralls commented Jul 30, 2024

Coverage Status

coverage: 97.01%. remained the same
when pulling e7e8553 on ElwynVdb:image-background-transparancy
into dbf0a3e on PHPOffice:master.

@Progi1984
Copy link
Member

@ElwynVdb Could you update the changelog, please ?

@Progi1984 Progi1984 added the Status: Waiting for feedback Question has been asked, waiting for response from PR author label Aug 15, 2024
@ElwynVdb
Copy link
Contributor Author

@Progi1984 Sure!, Changelog has been updated.

@Progi1984 Progi1984 merged commit a7b9030 into PHPOffice:master Aug 15, 2024
13 checks passed
@Progi1984
Copy link
Member

Progi1984 commented Aug 15, 2024

Thanks @ElwynVdb for your contribution

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Status: Waiting for feedback Question has been asked, waiting for response from PR author
Development

Successfully merging this pull request may close these issues.

3 participants