Add default font color for Word (.docx) #2700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the abillity to add a default font color for generated .docx.
Add default font color
Add documentation default font color
Correct default value
add tests for SetGetDefaultFontColor
debuging the tests
Progi1984
reviewed
Nov 24, 2024
As suggested Co-authored-by: Progi1984 <progi1984@gmail.com>
As suggested Co-authored-by: Progi1984 <progi1984@gmail.com>
Add default font color
Add documentation default font color
Correct default value
As suggested Co-authored-by: Progi1984 <progi1984@gmail.com>
As suggested Co-authored-by: Progi1984 <progi1984@gmail.com>
Fixed Formating
Progi1984
reviewed
Jan 14, 2025
Progi1984
reviewed
Jan 14, 2025
There was a problem hiding this comment.
One improvement in unit test and I can merge it after.
Good job @Collie-IT
add test for default color
|
@Collie-IT It seems there is a merge conflict. Could you fix it ? |
# Conflicts: # docs/changes/1.x/1.4.0.md # src/PhpWord/PhpWord.php # src/PhpWord/Settings.php # tests/PhpWordTests/PhpWordTest.php
resolve merge conflict
Progi1984
approved these changes
Jan 26, 2025
|
Thanks @Collie-IT for your contribution 🥳 |
This was referenced Jan 28, 2025
4 tasks
4 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the abillity to add a default font color for generated .docx.
Description
Adds the abillity to add a default font color for generated .docx.
Fixes # (issue)
Checklist: