Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Proper css inline border #1670 #2728

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Proper css inline border #1670 #2728

wants to merge 22 commits into from

Conversation

Azamat8405
Copy link
Contributor

@Azamat8405 Azamat8405 commented Jan 23, 2025 •
edited
Loading

Description

Fixes #1670

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

@coveralls
Copy link

coveralls commented Jan 23, 2025 •
edited
Loading

Coverage Status

coverage: 96.807% (+0.04%) from 96.767%
when pulling ae3767f on Azamat8405:properCSSInlineBorder1670
into 6ca8c9f on PHPOffice:master.

Progi1984
Progi1984 reviewed Feb 12, 2025
View reviewed changes
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Azamat8405 Could you add unit tests with differents combinations of styles, please ?

@Progi1984 Progi1984 added the Status: Waiting for feedback Question has been asked, waiting for response from PR author label Feb 12, 2025
@Azamat8405
Copy link
Contributor Author

@Progi1984, i have issue with getMockForAbstractClass method during PHP Static Analysis.

could you check it please?

@Azamat8405 Azamat8405 requested a review from Progi1984 February 18, 2025 10:40
@Azamat8405 Azamat8405 mentioned this pull request Feb 27, 2025
Closed
4 tasks
@Azamat8405
Copy link
Contributor Author

@Progi1984 hello!
Could you review current PR again please.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Progi1984 Progi1984 Awaiting requested review from Progi1984

Assignees
No one assigned
Labels
Status: Waiting for feedback Question has been asked, waiting for response from PR author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

addHtml > proper CSS inline border
3 participants
@Azamat8405 @coveralls @Progi1984