Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Option to Write Hyperlink Rather than Label to Csv #4151

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

oleibman
Copy link
Collaborator

Fix #1412 which had gone stale and which I've reopened. Add boolean property preferHyperlinkToLabel with setter and getter to Csv Writer. Default is false, so no BC problems; in addition, true will probably add quite a bit of overhead.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.

Owen Leibman and others added 3 commits August 26, 2024 12:56
Fix PHPOffice#1412 which had gone stale and which I've reopened. Add boolean property `preferHyperlinkToLabel` with setter and getter to Csv Writer. Default is false, so no BC problems; in addition, true will probably add quite a bit of overhead.
@oleibman oleibman enabled auto-merge October 8, 2024 04:27
@oleibman oleibman added this pull request to the merge queue Oct 8, 2024
Merged via the queue into PHPOffice:master with commit 88c517f Oct 8, 2024
12 of 13 checks passed
@oleibman oleibman deleted the issue1412 branch October 8, 2024 04:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Export to csv from excel including hyperlink
1 participant