Skip to content

ClusterReplication drivers are saving erroneous expiration date in low-level backends #855

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Geolim4 opened this issue Mar 29, 2022 · 3 comments · Fixed by #857
Closed

ClusterReplication drivers are saving erroneous expiration date in low-level backends #855

Geolim4 opened this issue Mar 29, 2022 · 3 comments · Fixed by #857
Assignees
@Geolim4
Labels
8.1 9.0 :) Closed ^_^ Fixed ~_~ Issue confirmed

Comments

@Geolim4
Copy link
Member

Geolim4 commented Mar 29, 2022

Configuration

  • PhpFastCache version: "8.x, 9.x"
  • PhpFastCache API version: "3x, 4x"
  • PHP version: "Irrelevant"
  • Operating system: "Irrelevant"

Describe the bug

The ClusterFullReplication and ClusterSemiReplication are saving erroneous expiration date in low-level backends. The saved date is a now date, not a now + "defaultTtl" date
@Geolim4 Geolim4 self-assigned this Mar 29, 2022
@github-actions
Copy link

Hello curious contributor !
Since it seems to be your first contribution, make sure that you've been:

  • Reading and searching out our WIKI
  • Reading and agreed with our Code Of Conduct
  • Reading and understood our Coding Guideline
  • Reading our README
    If everything looks unclear to you, tell us what 😄
    The Phpfastcache Team

@Geolim4
Copy link
Member Author

Geolim4 commented Mar 29, 2022

Stupid bot, who the hell coded you ?

Geolim4 added a commit that referenced this issue Mar 29, 2022
@Geolim4
Fixed #855
37f3ca4
Geolim4 added a commit that referenced this issue Mar 30, 2022
@Geolim4
Fixed #855
a7412d3
Geolim4 added a commit that referenced this issue Mar 30, 2022
@Geolim4
Added tests for #855
51a3619
Geolim4 added a commit that referenced this issue Mar 30, 2022
@Geolim4
Fixed #855 (v8)
0d1e288
Geolim4 added a commit that referenced this issue Mar 30, 2022
@Geolim4
Fixed #855 (v8)
42ddab0
@Geolim4 Geolim4 changed the title ClusterFullReplication and ClusterSemiReplication are saving erroneous expiration date in low-level backends ClusterReplication drivers are saving erroneous expiration date in low-level backends Mar 30, 2022
@Geolim4
Copy link
Member Author

Geolim4 commented Mar 30, 2022

Will be fixed in 8.1 and 9.1.

The 9.1 release will immediately follow the 9.0.2.

@Geolim4 Geolim4 closed this as completed Mar 30, 2022
@Geolim4 Geolim4 mentioned this issue Apr 3, 2022
Merged
6 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Geolim4 Geolim4

Labels
8.1 9.0 :) Closed ^_^ Fixed ~_~ Issue confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Released 9.1.0 PHPSocialNetwork/phpfastcache
1 participant
@Geolim4