feat:add power-control interface #439
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-Xiafeng
reviewed
Mar 10, 2025
huyongqii
force-pushed
the
power-control
branch
from
24a6e05 to
c31b12a
Compare
L-Xiafeng
reviewed
Mar 12, 2025
Comment on lines
293
to
305
| crane::grpc::plugin::GetCranedListHookReply PluginClient::GetCranedListHookSync(crane::grpc::CranedListType type) { | ||
| grpc::ClientContext context; | ||
| crane::grpc::plugin::GetCranedListHookRequest request; | ||
| crane::grpc::plugin::GetCranedListHookReply reply; | ||
|
|
||
| request.set_type(type); | ||
|
|
||
| auto status = m_stub_->GetCranedListHook(&context, request, &reply); | ||
| if (!status.ok()) { | ||
| CRANE_ERROR("[Plugin] Failed to get craned list: {}; {} (code: {})", | ||
| context.debug_error_string(), status.error_message(), | ||
| int(status.error_code())); | ||
| throw std::runtime_error("Failed to get craned list"); |
There was a problem hiding this comment.
我们不用异常，这里Sync的实现需要和@Nativu5 check一下
huyongqii
force-pushed
the
power-control
branch
from
c31b12a to
3418449
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.