Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix CAS computation #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

sup3rgiu
Copy link

  • missing optimizer.zero_grad()
  • validation accuracy was computed on the training set instead of the validation set
  • fix log

Also, I believe would be better to generate a fake dataset only once and use it to train the classifier for N epochs.
So, the correct pipeline would be:

  1. Generate a fake dataset of the same length (and same number of images per class, preferably) of the original training dataset (e.g: CIFAR10 -> 5000 images per class)
  2. Shuffle the dataset
  3. Train the classifier for N epochs and at the end of each epoch compute the accuracy on the original validation dataset

- missing optimizer.zero_grad()
- validation accuracy was computed on the training set instead of the validation set
- fix log
@mingukkang
Copy link
Collaborator

Thanks. I will review the PR and reflect it if there is no problem.

Again thank you for your contribution!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants