Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
build: Package
prqlc
as Snap #1881build: Package
prqlc
as Snap #1881Changes from 5 commits
bc8f8ae
3c0d0d8
2e2e165
dd0ecf1
92072a4
610e6ee
76df86c
d1849c3
c2c5c35
fd0e568
534ce48
2033d31
aaeb274
b3e661e
7fd84eb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lower priority but before we merge — we should have this be correct version and have something like this in the
prqlc
Cargo.toml so it gets update on every release:prql/prql-js/Cargo.toml
Lines 44 to 48 in b430f03
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative would be to set the version property to
git
which would expand it using thegit describe
command to something like0.2.5-690-g311ccd9
as per the documentation. https://snapcraft.io/docs/snapcraft-yaml-referenceThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, good idea re
git
; this will give us a good result when we're on a tag