Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[cherry-pick] [PHI] Sum op migration (#46239) #46730

Closed
wants to merge 1 commit into from
Closed

[cherry-pick] [PHI] Sum op migration (#46239) #46730

wants to merge 1 commit into from

Conversation

Silv3S
Copy link
Member

@Silv3S Silv3S commented Oct 3, 2022

PR types

Others

PR changes

Others

Describe

Migrate sum(add) operator to phi

@paddle-bot
Copy link

paddle-bot bot commented Oct 3, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Oct 3, 2022
@Silv3S Silv3S added Intel and removed contributor External developers status: proposed labels Oct 3, 2022
@Silv3S Silv3S mentioned this pull request Oct 3, 2022
Closed
@paulinagacek @Silv3S
[PHI] Sum op migration (PaddlePaddle#46239)
4e2478a 
* Sum kernel migrated to phi

* Static cast added, file name changed

* OneDNNGetDataType to uppercase

* refactoring

* AddOneDNNHandler changed to SumOneDNNHandler
@paddle-bot-old paddle-bot-old bot added the contributor External developers label Oct 3, 2022
@Silv3S
Copy link
Member Author

Silv3S commented Oct 11, 2022

@YuanRisheng cherry-picking oneDNN sum kernel fails to build. I checked locally and it works when combined with #45860. Can I cherry-pick both of them?

@YuanRisheng
Copy link
Contributor

YuanRisheng commented Oct 12, 2022 •
edited
Loading

@YuanRisheng cherry-picking oneDNN sum kernel fails to build. I checked locally and it works when combined with #45860. Can I cherry-pick both of them?

PR#45860 modifies basics-data structures in Paddle. After thinking further yesterday, we decide not to cherry-pick it for stable version(Paddle 2.4). Maybe it needs more validation. So, you could close this pr. Thank you.

@Silv3S Silv3S closed this Oct 12, 2022
@paddle-bot
Copy link

paddle-bot bot commented Oct 12, 2022

很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@Silv3S Silv3S deleted the phi_7 branch October 12, 2022 09:14
@paddle-bot-old paddle-bot-old bot removed the contributor External developers label Oct 17, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Silv3S @YuanRisheng @paulinagacek