Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PHI] gaussian_random kernel fix accuracy drop #46747

Merged
merged 1 commit into from
Oct 9, 2022

Conversation

Silv3S
Copy link
Member

@Silv3S Silv3S commented Oct 4, 2022

PR types

Bug fixes

PR changes

Others

Describe

During PHI migration framework::GetCPURandomEngine() was removed. In PR #45481 I didn't add extra seed check to generator, which resulted in accuracy drop in hapi_mnist_bf16_static.py.

This PR adds seed check and restores desired accuracy

@Silv3S Silv3S added the Intel label Oct 4, 2022
@paddle-bot-old paddle-bot-old bot added the contributor External developers label Oct 4, 2022
Copy link
Contributor

@jakpiase jakpiase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanRisheng YuanRisheng merged commit 97ec57f into PaddlePaddle:develop Oct 9, 2022
@Silv3S Silv3S deleted the phi_fix_gaussian_accuracy branch October 9, 2022 05:09
@paddle-bot-old paddle-bot-old bot removed the contributor External developers label Oct 17, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants