-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[CodeStyle] add more information when codestyle check failed #47116
Merged
luotao1
merged 17 commits into
PaddlePaddle:develop
from
cattidea:pre-commit/ci/add-more-info-when-failed
Oct 19, 2022
Merged
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
4b669e8
[CodeStyle] add more information when codestyle check failed
SigureMo 00d9688
empty commit, test=document_fix
SigureMo 6240872
add an unused import to trigger flake8 F401 error, test=document_fix
SigureMo 64ba559
add a yapf error, test=document_fix
SigureMo a6c6684
try to fix diff_files, test=document_fix
SigureMo dbc502d
try to fix diff_files, test=document_fix
SigureMo 47761c5
try to fix diff_files, test=document_fix
SigureMo 873c42d
try to fix diff_files, test=document_fix
SigureMo 1c38c3a
try to fix diff_files, test=document_fix
SigureMo 43bda11
try to fix diff_files, test=document_fix
SigureMo 98d7fa0
only echo command when number of diff_files <= 100
SigureMo f4e04e9
empty commit, test=document_fix
SigureMo 692beb1
empty commit, test=document_fix
SigureMo 9e1f804
remove unnecessary `[*]`, test=document_fix
SigureMo 93ab320
longer divider, test=document_fix
SigureMo 61da5b4
revert two unrelated files
SigureMo fdc45d2
empty commit, test=document_fix
SigureMo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,7 @@ | |
import re | ||
import os | ||
import sys | ||
import argparse | ||
|
||
|
||
def analysisPyXml(rootPath, ut): | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
仅仅提示安装命令只能保证新的 commit 可以通过,而不能保证 PR 里之前的 commit 通过,因此这里命令用于提示如何复现这个 PR 里的全部问题
这里提示的命令与 37 行一致,以保证本地可以复现/自动修复 CI 上的相关问题
为避免一些较大的 PR(如一些全量替换)时这里命令长度过长导致难以注意到有效的信息,仅仅会在修改文件数量小于等于 100 时提示本信息
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其余两个文件目前只是用于触发 pre-commit 测试效果,如果没有问题就可以直接恢复了