Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PHI] Migrate matmul_grad kernel #48023

Merged
merged 34 commits into from
Nov 18, 2022
Merged

[PHI] Migrate matmul_grad kernel #48023

merged 34 commits into from
Nov 18, 2022

Conversation

Silv3S
Copy link
Member

@Silv3S Silv3S commented Nov 15, 2022

PR types

Others

PR changes

Others

Describe

  • Migrate matmul_grad kernel to PHI,
  • migrate methods which will be reused for matmul kernel.

Silv3S added 30 commits November 8, 2022 09:14
@Silv3S
cleanup unused code
b2c89e6
@Silv3S
unify is_int8 is_bfloat16
1be88bc
@Silv3S
Simplify matmul_v2 FWD kernel
4f82616
@Silv3S
remove RunKernel methods
f5375fd
@Silv3S
remove import namespace
9c927fa
@Silv3S
remove headers
6dd70a1
@Silv3S
Merge branch 'develop' into mkldnn_cleanup
f763164
@Silv3S
Merge branch 'PaddlePaddle:develop' into mkldnn_cleanup
f613c3f
@Silv3S
clean fluid/phi cross imports
02392d3
@Silv3S
remove fluid axpy_handler
a3c0c61
@Silv3S
delete fluid methods
fbf1605
@Silv3S
Merge branch 'mkldnn_cleanup' into axpy_fluid_phi
e8dcc47
@Silv3S
activations
cc3b784
@Silv3S
OneDNNMemDesc
0994e24
@Silv3S
MKLDNNFormatForSize
6dbfddf
@Silv3S
MatchShapeToLayout
de56962
@Silv3S
MKLDNNMemoryFormat
1bc636b
@Silv3S
MKLDNNFormat
387a16b
@Silv3S
ReorderMKLDNNHandler
7536353
@Silv3S
to_void_cast
38427c2
@Silv3S
Merge branch 'axpy_fluid_phi' into mkldnn_cleanup
6ff7998
@Silv3S
review suggestions
206afcb
@Silv3S
interpolate
ee87e9c
@Silv3S
Merge branch 'develop' into mkldnn_cleanup
6ca8717
@Silv3S
remove fluid depedency
0c9ca31
@Silv3S
Merge branch 'develop' into mkldnn_cleanup
d0d94d4
@Silv3S
init
4780111
@Silv3S
ExecuteMatMulV2
17684e0
@Silv3S
rm fluid kernel
efb3932
@Silv3S
Merge branch 'develop' into phi_matmul_grad_kernel
2c968e7
@paddle-bot
Copy link

paddle-bot bot commented Nov 15, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Nov 15, 2022
@Silv3S Silv3S added Intel and removed contributor External developers status: proposed labels Nov 15, 2022
@paddle-bot-old paddle-bot-old bot added the contributor External developers label Nov 15, 2022
@Silv3S Silv3S mentioned this pull request Nov 16, 2022
Closed
@Silv3S Silv3S requested a review from YuanRisheng November 17, 2022 14:14
sfraczek
sfraczek approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@sfraczek sfraczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotrekobi piotrekobi self-requested a review November 17, 2022 16:08
piotrekobi
piotrekobi approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@piotrekobi piotrekobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanRisheng
Copy link
Contributor

The CI-coverage is not successful. Please check if the MatmulGradKernel is called. You can check this unittest: test_matmul_v2_mkldnn_op. If kernel is called, I will mark this ci as successful. Otherwise, I will help you to find the reason why they are not called. Thank you.

@Silv3S
Copy link
Member Author

Silv3S commented Nov 18, 2022

@YuanRisheng thank you for reply. OneDNN version of matmul_grad kernel is called in this unit test

@YuanRisheng YuanRisheng merged commit 4ab18ad into PaddlePaddle:develop Nov 18, 2022
@Silv3S Silv3S deleted the phi_matmul_grad_kernel branch November 18, 2022 10:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sfraczek sfraczek sfraczek approved these changes

@YuanRisheng YuanRisheng YuanRisheng approved these changes

@piotrekobi piotrekobi piotrekobi approved these changes

Assignees

@iclementine iclementine

Labels
contributor External developers Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Silv3S @YuanRisheng @sfraczek @piotrekobi @iclementine