【Infer Symbolic Shape No.11】【BUAA】 Add box_coder op #67864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
MufanColin
changed the title
luotao1
added
contributor
gongshaotian
reviewed
Sep 2, 2024
| phi::errors::InvalidArgument( | ||
| "The dimension of Input(PriorBoxVar) should be equal to " | ||
| "the dimension of Input(PriorBox) in BoxCoder operator " | ||
| "when the rank is 2.")); |
There was a problem hiding this comment.
这里需要写个循环，逐元素添加equalcstr
gongshaotian
reviewed
Sep 2, 2024
| infer_context->SetShapeOrDataForValue( | ||
| op->result(0), | ||
| symbol::ShapeOrDataDimExprs{symbol::TensorShapeOrDataDimExprs( | ||
| {target_box_shape[0], prior_box_shape[0], 4})}); |
There was a problem hiding this comment.
顺便改成symbol::DimExpr(4)吧
luotao1
approved these changes
Sep 4, 2024
33 tasks
| const std::string &code_type = | ||
| op->attribute<pir::StrAttribute>("code_type").AsString(); | ||
| int axis = op->attribute<pir::Int32Attribute>("axis").data(); | ||
| const std::vector<float> &variance = |
There was a problem hiding this comment.
variance 定义了但没有用到，在clang会报错，不需要可以删除
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Improvements
Description
添加 box_coder 算子符号推导接口。