【BUAA】【Infer Symbolic Shape】添加 weight_only_linear op的符号推导接口 #67875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
标题修改一下，添加 weight_only_linear op的符号推导接口 |
gongshaotian
reviewed
Sep 4, 2024
| auto weight_scale_shape = weight_scale_shape_or_data.shape(); | ||
| auto x_shape = x_shape_or_data.shape(); | ||
| auto weight_shape = weight_shape_or_data.shape(); | ||
| auto n = group_size == -1 ? weight_scale_shape[0] : weight_scale_shape[1]; |
| // 0, | ||
| // common::errors::InvalidArgument( | ||
| // "The second dimension of input must be divisible by 16, but | ||
| // got[%d]", weight_shape[1])); |
There was a problem hiding this comment.
把这两个Enforce的注释删了，修改成TODO项
| "Input(X) dim[-1] and Input(Weight) dim[1] should be equal." | ||
| "But received Input(X) dim[-1](%s) != Input(Weight) dim[1](%s)", | ||
| x_shape[x_shape.size() - 1], | ||
| weight_shape[1])); |
| x_shape[x_shape.size() - 1], | ||
| weight_shape[1])); | ||
| if (!bias_shape_or_data.isa<symbol::NullShapeOrDataDimExpr>()) { | ||
| auto bias_shape = bias_shape_or_data.shape(); |
| "The input(weight_scale) must be a 2D Tensor" | ||
| " in groupwise mode.")); | ||
| PADDLE_ENFORCE_EQ(weight_scale_shape[0], | ||
| (weight_shape[1] + (group_size - 1)) / group_size, |
Jeff114514
changed the title
gongshaotian
approved these changes
Sep 6, 2024
|
|
||
| ExprVec weight_scale_shape = weight_scale_shape_or_data.shape(); | ||
| ExprVec x_shape = x_shape_or_data.shape(); | ||
| ExprVec weight_shape = weight_shape_or_data.shape(); |
luotao1
approved these changes
Sep 6, 2024
33 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Others
Description
增加了新的符号推导
测试位于test_weight_only_linear.py 缺失optest
约束信息暂未修改，沿用了infermeta的PADDLE_ENFORCE