Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

【complex op No.50】tan_coo/tan_csr(sparse) #67885

Merged
merged 4 commits into from
Sep 3, 2024
Merged

【complex op No.50】tan_coo/tan_csr(sparse) #67885

merged 4 commits into from
Sep 3, 2024

Conversation

Aoraki-Dream
Copy link
Contributor

@Aoraki-Dream Aoraki-Dream commented Aug 31, 2024

PR Category

Operator Mechanism

PR Types

New features

Description

add complex support for tan_coo/tan_csr in sparse

Copy link

paddle-bot bot commented Aug 31, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Aoraki-Dream Aoraki-Dream marked this pull request as draft August 31, 2024 03:56
@Aoraki-Dream
Copy link
Contributor Author

Aoraki-Dream commented Aug 31, 2024

中间分支提交历史混乱,修改之后重新提交pr,请老师检查 @luotao1 @zhiminzhang0830

@Aoraki-Dream Aoraki-Dream marked this pull request as ready for review August 31, 2024 07:14
@Aoraki-Dream Aoraki-Dream marked this pull request as draft August 31, 2024 11:05
@Aoraki-Dream Aoraki-Dream marked this pull request as ready for review August 31, 2024 13:40
@paddle-bot paddle-bot bot added the contributor External developers label Aug 31, 2024
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Sep 2, 2024
Copy link
Contributor

@zhiminzhang0830 zhiminzhang0830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -91,7 +91,7 @@ def tan(x: Tensor, name: str | None = None) -> Tensor:
out = tan(x)

Parameters:
x (Tensor): The input Sparse Tensor with data type float32, float64.
x (Tensor): The input Sparse Tensor with data type float32, float64, complex64, complex128.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请对应更新下 docs repo的中文文档。

@luotao1 luotao1 merged commit 3480714 into PaddlePaddle:develop Sep 3, 2024
29 checks passed
@luotao1
Copy link
Contributor

luotao1 commented Sep 3, 2024

hi, @Aoraki-Dream

  • 非常感谢你对飞桨的贡献,我们正在运营一个PFCC组织,会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨做贡献,详情可见 https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣,请发送邮件至 ext_paddle_oss@baidu.com,我们会邀请你加入~

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants