【Infer Symbolic Shape No.168】【BUAA】 Add partial sum op #67888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
gongshaotian
reviewed
Sep 2, 2024
| phi::errors::InvalidArgument("Only support two dimensions input now.")); | ||
| if (i == 0) { | ||
| batch_size = x_shape[0]; | ||
| input_len = x_shape[1]; |
gongshaotian
reviewed
Sep 2, 2024
| PADDLE_ENFORCE_GT( | ||
| static_cast<int>(input_len.Get<std::int64_t>()), | ||
| start_index, | ||
| phi::errors::OutOfRange("start_index must be less than input len")); |
There was a problem hiding this comment.
删掉这个enforce吧，input_len不一定是int类型，或者在enforce前加个Dimexpr的类型判断
There was a problem hiding this comment.
我将这个 enforce 删除了。
gongshaotian
reviewed
Sep 2, 2024
| PADDLE_ENFORCE_GE(static_cast<int>(input_len.Get<std::int64_t>()), | ||
| start_index + length, | ||
| phi::errors::OutOfRange( | ||
| "start_index + length is larger than input length")); |
There was a problem hiding this comment.
我将这个 enforce 删除了。
|
补充一下单测状态 |
已补充。 |
gongshaotian
approved these changes
Sep 4, 2024
Try to fix some errors
33 tasks
|
PR-CI-Hygon-DCU 无权限重新运行。 |
|
rerun了coverage里的paddle-test，这次应该没问题 |
|
好像还是没有过 |
luotao1
approved these changes
Sep 6, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Improvements
Description
添加 partial sum 算子符号推导接口。