Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix bug when combining sequence parallel and gradient merge #854

Merged
merged 5 commits into from
Nov 1, 2022
Merged

Fix bug when combining sequence parallel and gradient merge #854

merged 5 commits into from
Nov 1, 2022

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Oct 28, 2022

RTT.

@sneaxiy sneaxiy changed the title [WIP] Fix bug when combining sequence parallel and gradient merge Fix bug when combining sequence parallel and gradient merge Oct 28, 2022
haohongxiang
haohongxiang approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@haohongxiang haohongxiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haohongxiang haohongxiang merged commit f9c2ba9 into PaddlePaddle:develop Nov 1, 2022
@sneaxiy sneaxiy deleted the fix_sp_gm_bug branch November 1, 2022 03:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@haohongxiang haohongxiang haohongxiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sneaxiy @haohongxiang