Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Unified checkpoint] PR cherry-picks #9277

Merged

Conversation

DesmonDay
Copy link
Contributor

PR types

Others

PR changes

Others

Description

  1. update async_save info.
  2. support expert_parallel.
  3. update async_save done files directory.
  4. fix async_save hang.
  5. support save generation_config in uc.

Copy link

paddle-bot bot commented Oct 16, 2024

Thanks for your contribution!

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DesmonDay DesmonDay merged commit 37b03fc into PaddlePaddle:release/3.0-beta2 Oct 16, 2024
5 checks passed
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 11.21076% with 198 lines in your changes missing coverage. Please review.

Project coverage is 52.95%. Comparing base (73f1a20) to head (8f6e88b).
Report is 51 commits behind head on release/3.0-beta2.

Files with missing lines Patch % Lines
paddlenlp/trainer/plugins/unified_checkpoint.py 5.64% 167 Missing ⚠️
paddlenlp/trainer/trainer.py 24.32% 28 Missing ⚠️
paddlenlp/trainer/trainer_utils.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/3.0-beta2    #9277      +/-   ##
=====================================================
- Coverage              53.02%   52.95%   -0.08%     
=====================================================
  Files                    656      656              
  Lines                 106153   106312     +159     
=====================================================
+ Hits                   56288    56295       +7     
- Misses                 49865    50017     +152     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants