[Trainer] fix save_model #9286
Merged
[Trainer] fix save_model #9286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
ZHUI
reviewed
Oct 17, 2024
| if isinstance(self.model, LoRAModel) and (self.model.quantized or self.args.pipeline_parallel_degree > 1): | ||
| self.save_model(output_dir, False, signal_dir) | ||
| elif isinstance(self.model, LoRAModel) or isinstance(self.model, PrefixModelForCausalLM): | ||
| self.save_model(output_dir, True, signal_dir) |
There was a problem hiding this comment.
signal_dir = os.path.join(signal_dir, os.path.split(output_dir)[-1])
ZHUI
previously approved these changes
Oct 17, 2024
DesmonDay
force-pushed
the
new_develop
branch
from
5b20bd3 to
6ebe5b6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9286 +/- ##
===========================================
- Coverage 53.27% 53.09% -0.19%
===========================================
Files 657 657
Lines 107194 106533 -661
===========================================
- Hits 57104 56559 -545
+ Misses 50090 49974 -116 ☔ View full report in Codecov by Sentry. |
DesmonDay
force-pushed
the
new_develop
branch
from
693d6fb to
2eafad3
Compare
DesmonDay
added a commit
to DesmonDay/PaddleNLP
that referenced
this pull request
Oct 17, 2024
* bug fix * bug fix
DesmonDay
added a commit
to DesmonDay/PaddleNLP
that referenced
this pull request
Oct 17, 2024
* bug fix * bug fix
wawltor
pushed a commit
that referenced
this pull request
Oct 17, 2024
wawltor
pushed a commit
that referenced
this pull request
Oct 17, 2024
* [Unified Checkpoint] Support expert parallel (#9055) * update code * [Unified Checkpoint] Fix generation config save (#9223) * [Unified Checkpoint] update async_save_info in develop (#9173) * [Unified Checkpoint] update async save logic (#9274) * update async save signal * fix async save hang * bug fix * bug fix * [Trainer] fix save_model (#9286) * bug fix * bug fix --------- Co-authored-by: Weiguo Zhu <DrownFish19@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Modify the
save_modelcall to enhance compatibility.