-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Nodify, bundle and deprecate old files #4
Conversation
Now tests run on Travis CLI instead of a virtual browser. Much faster and cleaner.
@tomalec ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it looks kinde hacky that just ot be able to do https://github.com/Palindrom/JSON-Patch-Queue/pull/4/files#diff-eb50505eb60eb228148efeebce771b5f
Write
module.exports = JSONPatchQueue;
module.exports.default = JSONPatchQueue;
instead of
if (typeof module !== "undefined") {
module.exports = JSONPatchQueue;
}
We need to load 75lines = 28% code more in the browser.
https://github.com/Palindrom/JSON-Patch-Queue/pull/4/files#diff-8abfd87d68e18e03b76cb3f3591fc129
gruntfile.js
Outdated
@@ -1,45 +0,0 @@ | |||
module.exports = function(grunt) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need bump task any longer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it's two files that we need to bump. And I thought Grunt with Webpack is too much. They share a lot of the functionality.
I'd rather expect it to be:
|
@tomalec done. I tested again all the above tests and copied HTML spec runner to test minified files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would bump the version after merge, with single bump commit.
Other than that LGTM.
bower.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "json-patch-queue", | |||
"version": "1.0.0", | |||
"version": "2.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you already bumped the version
LGTM, please merge, and bump major version |
Related to Palindrom/JSON-Patch-OT#5.
This is 100% backward compatible. Yet 100% Node and future Palindrom compatible.
Tested with Browser
<script />
, Node CommonJS, Babel ES6 imports and TS imports. All Jasmine tests pass on Node and browser.With great Typings files, thanks to @tomalec awesome JSDoc.
Usage examples (tested each):
or
in Node's CommonJS
Or
in Node's TS and ES6
or