Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Expand biome api #11952

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Expand biome api #11952

wants to merge 28 commits into from

Conversation

masmc05
Copy link
Contributor

@masmc05 masmc05 commented Jan 12, 2025

Expand the biome api by providing more biome specific data. World generation biome related data is out of scope of this pr.

@masmc05 masmc05 requested a review from a team as a code owner January 12, 2025 04:17
@Warriorrrr Warriorrrr added type: feature Request for a new Feature. scope: api labels Jan 12, 2025
masmc05 and others added 4 commits January 12, 2025 16:13
@masmc05 @Warriorrrr
Update paper-api/src/main/java/io/papermc/paper/world/biome/BiomeClim…
095d5e8 
…ate.java

Co-authored-by: Warrior <50800980+Warriorrrr@users.noreply.github.com>
@masmc05
Remove @inheritdoc
984d531
@masmc05
Make return types on CraftBiome consistent
1d4b609
@masmc05 @Warriorrrr
Fix wiki link
c96db0d 
Co-authored-by: Warrior <50800980+Warriorrrr@users.noreply.github.com>
@masmc05 masmc05 mentioned this pull request Jan 14, 2025
Merged
@masmc05
Copy link
Contributor Author

masmc05 commented Feb 13, 2025

Applied requested changes

@masmc05 masmc05 requested a review from lynxplay February 25, 2025 21:38
kennytv
kennytv approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@kennytv kennytv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General approval, haven't tested it:tm:

lynxplay
lynxplay requested changes Feb 28, 2025
View reviewed changes
@masmc05
Copy link
Contributor Author

masmc05 commented Feb 28, 2025

Applied requested changes

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lynxplay lynxplay lynxplay requested changes

@Lulu13022002 Lulu13022002 Lulu13022002 left review comments

@Warriorrrr Warriorrrr Warriorrrr left review comments

@kennytv kennytv kennytv approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
scope: api type: feature Request for a new Feature.
Projects
Paper PR Queue
Status: Changes required
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@masmc05 @kennytv @lynxplay @Lulu13022002 @Warriorrrr