Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

add spigot.yml docs #221

Merged
merged 30 commits into from
Sep 5, 2023
Merged

add spigot.yml docs #221

merged 30 commits into from
Sep 5, 2023

Conversation

456dev
Copy link
Contributor

@456dev 456dev commented Aug 20, 2023

No description provided.

@456dev
fix for non-leaf yaml keys named default or description
04426e8
@456dev
add blank spigot.yml config docs
04d5b74 
copied file from spigot.yml on server running Paper version git-Paper-132 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: eb8f2bb)
@456dev
start editing config
b442671 
finish "settings" section
@456dev 456dev changed the title [DRAFT] add spigot.yml docs add spigot.yml docs Aug 20, 2023
456dev
456dev commented Aug 21, 2023
View reviewed changes
Copy link
Contributor Author

@456dev 456dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notes for myself later

docs/paper/admin/reference/configuration/spigot-configuration.mdx Outdated Show resolved Hide resolved
docs/paper/admin/reference/configuration/spigot-configuration.mdx Outdated Show resolved Hide resolved
docs/paper/admin/reference/configuration/spigot-configuration.mdx Outdated Show resolved Hide resolved
docs/paper/admin/reference/configuration/spigot-configuration.mdx Outdated Show resolved Hide resolved
docs/paper/admin/reference/configuration/spigot-configuration.mdx Outdated Show resolved Hide resolved
@456dev 456dev marked this pull request as ready for review August 21, 2023 12:28
@olijeffers0n olijeffers0n self-requested a review August 27, 2023 20:26
olijeffers0n
olijeffers0n approved these changes Aug 27, 2023
View reviewed changes
Copy link
Member

@olijeffers0n olijeffers0n left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved subject to a thorough reading of all descriptions - I have read most but need re-checking

olijeffers0n
olijeffers0n requested changes Aug 28, 2023
View reviewed changes
docs/paper/admin/reference/configuration/spigot-configuration.mdx Show resolved Hide resolved
docs/paper/admin/reference/configuration/spigot-configuration.mdx Outdated Show resolved Hide resolved
docs/paper/admin/reference/configuration/spigot-configuration.mdx Outdated Show resolved Hide resolved
docs/paper/admin/reference/configuration/spigot-configuration.mdx Outdated Show resolved Hide resolved
docs/paper/admin/reference/configuration/spigot-configuration.mdx Outdated Show resolved Hide resolved
docs/paper/admin/reference/configuration/spigot-configuration.mdx Outdated Show resolved Hide resolved
docs/paper/admin/reference/configuration/spigot-configuration.mdx Outdated Show resolved Hide resolved
docs/paper/admin/reference/configuration/spigot-configuration.mdx Outdated Show resolved Hide resolved
docs/paper/admin/reference/configuration/spigot-configuration.mdx Outdated Show resolved Hide resolved
@456dev @olijeffers0n
Apply suggestions from code review
8e186c8 
Co-authored-by: Ollie <69084614+olijeffers0n@users.noreply.github.com>
Lulu13022002
Lulu13022002 reviewed Aug 30, 2023
View reviewed changes
docs/paper/admin/reference/configuration/spigot-configuration.mdx Outdated Show resolved Hide resolved
docs/paper/admin/reference/configuration/spigot-configuration.mdx Outdated Show resolved Hide resolved
docs/paper/admin/reference/configuration/spigot-configuration.mdx Outdated Show resolved Hide resolved
docs/paper/admin/reference/configuration/spigot-configuration.mdx Outdated Show resolved Hide resolved
docs/paper/admin/reference/configuration/spigot-configuration.mdx Show resolved Hide resolved
docs/paper/admin/reference/configuration/spigot-configuration.mdx Outdated Show resolved Hide resolved
docs/paper/admin/reference/configuration/spigot-configuration.mdx Outdated Show resolved Hide resolved
docs/paper/admin/reference/configuration/spigot-configuration.mdx Outdated Show resolved Hide resolved
docs/paper/admin/reference/configuration/spigot-configuration.mdx Outdated Show resolved Hide resolved
docs/paper/admin/reference/configuration/spigot-configuration.mdx Show resolved Hide resolved
@456dev @Lulu13022002
Update docs/paper/admin/reference/configuration/spigot-configuration.mdx
de54044 
Co-authored-by: Lulu13022002 <41980282+Lulu13022002@users.noreply.github.com>
@456dev @Lulu13022002
Update docs/paper/admin/reference/configuration/spigot-configuration.mdx
60adfad 
Co-authored-by: Lulu13022002 <41980282+Lulu13022002@users.noreply.github.com>
@456dev
Merge branch 'main' into the456gamer-add-spigot-yml
18d575d 
# Conflicts:
#	src/components/Config.tsx
@olijeffers0n olijeffers0n merged commit ca44825 into PaperMC:main Sep 5, 2023
@Nacioszeczek Nacioszeczek mentioned this pull request Sep 23, 2023
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@olijeffers0n olijeffers0n olijeffers0n approved these changes

@powercasgamer powercasgamer Awaiting requested review from powercasgamer

@Lulu13022002 Lulu13022002 Awaiting requested review from Lulu13022002

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@456dev @powercasgamer @Lulu13022002 @olijeffers0n