Skip to content

fix(core): handle setting falsy value in proxy providers #118

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jan 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export class ProxyProviderManager {
return getProvider()[prop];
},
set(_, prop, value) {
return (getProvider()[prop] = value);
return Reflect.set(getProvider(), prop, value);
},
ownKeys() {
return Reflect.ownKeys(getProvider());
Expand Down
23 changes: 23 additions & 0 deletions packages/core/test/proxy-providers/proxy-providers.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ import {
ProxyResult,
ProxyResults,
} from './expect-ids-proxy';
import { globalClsService } from '../../src/lib/cls-service.globals';
import { ProxyProviderManager } from '../../src/lib/proxy-provider';

@Injectable()
class InjectedClass {
Expand Down Expand Up @@ -142,3 +144,24 @@ describe('Proxy providers', () => {
await expectOkIdsProxy(app);
});
});

describe('Edge cases', () => {
it('proxy should allow setting falsy value', async () => {
const clsService = globalClsService;
const symbol = Symbol('testSymbol');
const proxyProvider = ProxyProviderManager.createProxyProvider({
provide: symbol,
type: 'object',
useFactory: () => ({
booleanTest: true,
}),
});
const proxy = proxyProvider.useFactory();
await clsService.run(async () => {
await ProxyProviderManager.resolveProxyProviders();
expect(proxy.booleanTest).toBe(true);
proxy.booleanTest = false;
expect(proxy.booleanTest).toBe(false);
});
});
});