-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
update draft to my github branch fix #1317 #1323
Conversation
Test TemplateIt:
|
I'm getting this:
even if I delete yarn.lock and node_modules... |
oh grrr, i heard something about yarn not playing kindly with tarballs & non-relative paths. lemme try another way |
that feeling when finding the bug & fixing it took less time than installing a dependency from github... |
Codecov Report
@@ Coverage Diff @@
## master #1323 +/- ##
=======================================
Coverage 56.24% 56.24%
=======================================
Files 148 148
Lines 2130 2130
Branches 304 304
=======================================
Hits 1198 1198
Misses 784 784
Partials 148 148 Continue to review full report at Codecov.
|
Sorry, went too fast there. That happened when I tried to signout. |
Hmm, this may be a red herring. I think my .env got smoked (somehow??) |
Test Cycle 2It:
Results: tested on Safari, I still wasn't able to type. Is the package in package.json correct? |
I gave this another crack. I tested the CSS hack from your PR (facebookarchive/draft-js#1356) and saw that it worked. I also verified that the There must be some other component in the tree that's behaving badly... Were you able to test this an verify it with your local Safari? |
some versions of safari need a -webkit prefix. |
Test Cycle 3It:
|
Verified! Bravo @mattkrick !! |
No description provided.