Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds a Portal mode to Build Mode #28123

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

Erikos66
Copy link
Contributor

@Erikos66 Erikos66 commented Jan 26, 2025

What Does This PR Do

Adds a portal tool to build mode, allowing the user to create portals.

Through the settings you can customize, appearance, behaviour and duration.

adds a new icon to buildmode.dmi;
image

Why It's Good For The Game

Having a more RP friendly way than the jarring GET or SEND is good, it may also prove useful during certain events.

Testing

Tested on a local server, appears to work as intended.

Here are some videos of the portal mode in action;

Settings

settings.mp4

In-use

portals.mp4

So far all features that I intended to include are included.
sorry for the terrible code 💀


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
add: Portal mode to buildmode.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Sprites This PR modifies the game sprites -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jan 26, 2025
@Contrabang Contrabang added the Feature This PR is a new addition to the game label Jan 26, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Jan 26, 2025
@1080pCat 1080pCat added the Administration This PR relates to ingame administration features label Jan 28, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge Testmerge Requested This PR has a pending testmerge request Testmerge Active This PR is currently testmerged on production and removed -Status: Awaiting review This PR is awaiting review from the review team labels Feb 10, 2025
Copy link
Member

@Burzah Burzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually after some testing in game during the TM, there are a few things that need to be adjusted. I am going to review this properly, but I am throwing up a change request to prevent accidental merge.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting merge This PR is ready for merge labels Feb 11, 2025
@Erikos66
Copy link
Contributor Author

Following fixes and changes were made per request;

  • Can now clear setting the destination by right clicking
  • Should report lifetime correctly at-least does on local
  • Exiting the settings no longer requires you to sit through the rest
  • Arbitrary 500 second limit was silly, swapped out for an arbitrary 999 second limit
  • Quick create portals no longer lands you in dense objects

@Erikos66
Copy link
Contributor Author

Changed up a lot of things + new features, hopefully it should be easier to understand;

  • Portal preview only visible to the owning client when selecting origin (Can also see where you clicked now)
  • Alt + click now deletes portals
  • Summary is hopefully easier to understand
  • Broken some things down into procs for readability

Probably the last additions ill be making, feedback is very welcome however.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Feb 12, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
-Status: Awaiting merge This PR is ready for merge Administration This PR relates to ingame administration features Feature This PR is a new addition to the game Sprites This PR modifies the game sprites Testmerge Active This PR is currently testmerged on production Testmerge Requested This PR has a pending testmerge request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants