Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

remove unnecessary proc get_roletext #28520

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

warriorstar-orion
Copy link
Contributor

What Does This PR Do

This PR removes /proc/get_roletext(role), a proc that does nothing but return its argument. It used to do something back when special roles were bitflags (#3025) but is no longer necessary.

Why It's Good For The Game

Code cleanup.

Testing

Ran CI.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

NPFC

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Feb 24, 2025
Copy link
Contributor

@Contrabang Contrabang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fuck this proc

@lewcc lewcc added this pull request to the merge queue Feb 24, 2025
Merged via the queue into ParadiseSS13:master with commit c293dd3 Feb 24, 2025
19 checks passed
@warriorstar-orion warriorstar-orion deleted the refactor/get-roletext branch February 24, 2025 17:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
-Status: Awaiting type assignment This PR is waiting for its type to be assigned internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants