Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Convoys #513

Merged
merged 15 commits into from
Oct 24, 2023
Merged

Convoys #513

merged 15 commits into from
Oct 24, 2023

Conversation

kingofmen
Copy link
Collaborator

Convert convoys from the port infrastructure in the country.

This takes a lot more code than you'd think for literally one line in the history file.

Idhrendur
Idhrendur reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@Idhrendur Idhrendur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial look is good, will continue reviewing tomorrow.

Idhrendur
Idhrendur approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@Idhrendur Idhrendur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kingofmen kingofmen merged commit fa3ccea into ParadoxGameConverters:main Oct 24, 2023
@kingofmen kingofmen deleted the convoys branch October 24, 2023 04:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Idhrendur Idhrendur Idhrendur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kingofmen @Idhrendur