Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Check if RQ_DASHBOARD_REDIS_URL is already populated #485

Merged
merged 1 commit into from
May 2, 2024

Conversation

HJJ256
Copy link
Contributor

@HJJ256 HJJ256 commented Mar 12, 2024

Description

RQ_DASHBOARD_REDIS_URL is getting repopulated after make_flask_app() method call with the default value when using RQ_DASHBOARD_SETTINGS option for giving path to config file.

Fixes # (issue)
Added a NULL check for app.config["RQ_DASHBOARD_REDIS_URL"] before populating it with redis_url or default value

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run tests (pytest) that prove my fix is effective or that my feature works
  • I have updated the CHANGELOG.md file accordingly

Please let me know where I need to upload the CHANGELOG.md, I do not see it in the repo

RQ_DASHBOARD_REDIS_URL is getting repopulated with the default value when using RQ_DASHBOARD_SETTINGS option for giving path to config file.
@cjlapao cjlapao merged commit 14b9f5a into Parallels:master May 2, 2024
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants