Ensure that the host is connected to Shared network #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legal90
force-pushed
the
refactor-port-forwarding
branch
from
746d299 to
b0acede
Compare
It allows to reduce `prlctl` calls. Actually, Shared network name is hard-coded in Parallels Desktop and it will not be changed in the near future.
With PD 11.2.1 and higher it will be automatically fixed by connecting host to Shared network. For older versions the exception will be raised.
legal90
force-pushed
the
refactor-port-forwarding
branch
from
b0acede to
c8e8e60
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes an issue caused by accidental disabling an option "Connect Mac to this network":
https://forum.parallels.com/threads/error-undefined-method-for-nil-nilclass-nomethoderror-with-pd-11.329996/
Since Parallels Desktop 11.2.1 it will be automatically fixed by connecting the host to Shared network forcibly. Otherwise, the human-readable error will be displayed.
This PR also contains some minor improvements reducing CLI calls during the network configuration.
cc: @Kasen