Skip to content
This repository was archived by the owner on Mar 24, 2021. It is now read-only.

Documentation clarifications. Remove unused pykafka.common.Message. #922

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DieterDePaepe
Copy link

@codecov-io
Copy link

codecov-io commented Feb 28, 2019

Codecov Report

Merging #922 into master will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #922      +/-   ##
==========================================
+ Coverage   83.15%   83.32%   +0.17%     
==========================================
  Files          36       36              
  Lines        3799     3797       -2     
  Branches      562      562              
==========================================
+ Hits         3159     3164       +5     
+ Misses        493      487       -6     
+ Partials      147      146       -1
Impacted Files Coverage Δ
pykafka/topic.py 80.41% <ø> (-2.07%) ⬇️
pykafka/simpleconsumer.py 85.49% <ø> (-0.67%) ⬇️
pykafka/protocol/message.py 88.14% <100%> (ø) ⬆️
pykafka/common.py 100% <100%> (ø) ⬆️
pykafka/balancedconsumer.py 89.76% <0%> (-1.17%) ⬇️
pykafka/connection.py 83.16% <0%> (-1%) ⬇️
pykafka/handlers.py 91.91% <0%> (-0.74%) ⬇️
pykafka/cluster.py 72.52% <0%> (+0.36%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c816efa...b6f32b7. Read the comment docs.

@emmettbutler emmettbutler requested review from emmettbutler and removed request for emmettbutler March 4, 2019 17:33
@emmettbutler
Copy link
Contributor

Looks great, thanks for the pull request. There are still a few instances of common.Message in docstrings, including in the protocol and in simpleconsumer.py. Once those are adjusted, this can be merged.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants