Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for Vulnerability" ignore x Armour" mod #733

Merged

Conversation

majochem
Copy link
Contributor

@majochem majochem commented Feb 7, 2025

Fixes # .

Description of the problem being solved:

  • Adds support for Invulnerability's "Hits against Cursed Enemies ignore X Armour"
  • Adds "Armour" / "IgnoreArmour" to physical damage effective DPS breakdown in Calcs
  • Notes:
    • This purposely does not modify the "Armour" mods/values directly to avoid conflict with Armour Break mechanics
    • This doesn't currently affect the "Impale" dmg calculation. As Impale is not currently part of PoE2, I did not touch that area
    • This currently only affects offence calculation. If we ever want to calculate the effect of Vulnerability on the player, it will need updates

Steps taken to verify a working solution

  • Mod gets parsed correctly
  • Affects effective DPS correctly
    • Does not cause negative Armour
    • Has no effect if enemy Armour is 0
    • Scales correctly with curse effect
  • Gets displayed correctly in breakdown

Link to a build that showcases this PR:

TestBuild

Before screenshot:

None

After screenshot:

Vulnerability Skill Gem
{6E4ACA84-C5A3-42AE-BB2D-00D230864D69}

Phys effective DPS Breakdown
{CA4385F9-7EE4-4785-9842-A6FA083AC2F5}

@majochem majochem marked this pull request as ready for review February 7, 2025 20:14
@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Feb 8, 2025
@LocalIdentity LocalIdentity changed the title Add support for Vulnerability Curse ("Hits against Cursed Enemies ignore X Armour") Add support for Vulnerability" ignore x Armour" mod Feb 8, 2025
@LocalIdentity LocalIdentity merged commit 20efcb4 into PathOfBuildingCommunity:dev Feb 8, 2025
2 checks passed
@majochem majochem deleted the vulnerabilitycurse branch February 13, 2025 12:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants