split-pay Add AccountManagementService / transfer capability to SDK #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a new service to the SDK for Account Management. This commit includes the functions ping, transferCredit, and transferDebit. Transfer functions can be used to move money between PaySafe master and sub-accounts. The ping function can be used to determine if the Account Management service is available.
PayLeaseBrian
changed the title
|
@jbPayLease Please take a look at this PR and let me know what you think. Most of the work is from your original commit. I mostly just added some tests, and cleaned up a couple of minor items revealed in testing. |
jbPayLease
approved these changes
Aug 31, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to add the capability to transfer funds among linked accounts to the paysafe SDK. As transfers are part of the Account Management API, this required adding Account Management to the SDK.
Highlights:
monitor- verifies that account management api is active and respondingtransferDebit- Move funds from the account identified in the API endpoint URI to the linked account in the body of the requesttransferCredit- Move funds from the linked account in the body of the request to the account identified in the API endpoint URI.Transferthat extendsJSONObjecttransferDebitandtransferCreditmethods