Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

don't use container #3

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

don't use container #3

wants to merge 12 commits into from

Conversation

robkooper
Copy link
Member

trying to fix github actions build

@mdietze
Copy link
Member

mdietze commented Aug 18, 2020

@robkooper looks like tests are failing. Should we force merge this PR and have @tezansahu address the issues with the tests in his open PR, or do you want to try and fix the tests here?

@robkooper
Copy link
Member Author

need to add default account and xml package for tests.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Alexey Shiklomanov <alexey.shiklomanov@gmail.com>
@ashiklom
Copy link
Member

ashiklom commented Nov 4, 2020

Looks like the problem is that GH Actions is running this with --workdir /github/workspace, which is messing with the BETY image entrypoint (which uses a relative file path). Not sure the best way to fix it. BETY should probably use absolute paths in its entrypoint.sh, but I feel like there must be a way to change the working directory of GH Actions docker runs.

https://github.com/PecanProject/rpecanapi/runs/1350179239#step:7:9

Might be able to get away with something hacky like using entrypoint: /bin/bash with args: /path/to/betyuser.sh carya illinois ....

Comment on lines +60 to +61
# entrypoint: /home/bety/script/betyuser.sh
args: user carya illinois "Carya Demo User" carya@example.com 1 1
Copy link
Member

@ashiklom ashiklom Nov 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I'm currently testing this out on a personal branch of this -- https://github.com/ashiklom/rpecanapi/runs/1386059263?check_suite_focus=true

UPDATE: This made it past this line, but failed on the actual R CMD check step.

Suggested change
# entrypoint: /home/bety/script/betyuser.sh
args: user carya illinois "Carya Demo User" carya@example.com 1 1
entrypoint: /bin/bash
args: /home/bety/script/betyuser.sh carya illinois "Carya Demo User" carya@example.com 1 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though, I guess setting entrypoint: /home/bety/script/betyuser.sh might be a more straightforward version of the same thing.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants