Scratch: Return Log Results via ContextAwareLogger #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r loggers in the logger stack
Saartank
requested changes
Feb 4, 2025
There was a problem hiding this comment.
We have not integrated these new log error display features into all log messages in sample logger in main.go, only in burst mode context log messages. We need to consider how to showcase this functionality in the demo and include that work in this PR.
Would it be a good idea to stop the program if the disk runs out of space? We could integrate this into the log stream code. Would it be easy to simulate?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LogStatsHandlerlogger that gathers basic timing and disk usage stats for each log message that occursContextAwareLogger's Debug/Info/Error methods to return the latest stats gathered byLogStatsHandler