Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor general server_ui code out of origin_ui #308

Closed
turetske opened this issue Oct 31, 2023 · 3 comments · Fixed by #398
Closed

Refactor general server_ui code out of origin_ui #308

turetske opened this issue Oct 31, 2023 · 3 comments · Fixed by #398
Assignees
Labels
internal Internal code improvements, not user-facing
Milestone

Comments

@turetske
Copy link
Collaborator

Due to implementing origin_ui first, there is a lot of origin specific code that actually code be more general. This should be refactored into server_ui instead of origin_ui so it can be used by other servers such as the cache, director, or namespace. Some of the code in cmd/origin_serve is also more general than just origin code.

@turetske turetske added the internal Internal code improvements, not user-facing label Oct 31, 2023
@turetske turetske self-assigned this Nov 6, 2023
@bbockelm bbockelm added this to the v7.4.0 milestone Nov 7, 2023
@haoming29
Copy link
Contributor

In #291 I refactored much of the authorization check code in web_ui which can be helpful in implementing this issue

@haoming29
Copy link
Contributor

This can be very helpful for #264 as it will greatly reduce repetitive logic we would create.

@haoming29
Copy link
Contributor

Looks like #355 will be heavily dependent on this PR in order not to generate duplicate code and #355 was marked as part of 7.3.0. @bbockelm Do you think we should prioritize this issue to get #355 unblocked?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
internal Internal code improvements, not user-facing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants