-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Refactor origin_ui to web_ui to reuse basic logic for server web UI/API #398
Conversation
- Reuse htpasswd auth and common APIs for all servers: /config /health - Move auth route to /api/v1.0/auth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some questions about how some of the files will work if we have multiple web-ui's enabled, which will definitely be possible in the future and I don't want us backed into a corner now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #308
/config
,/health
to all servers/api/v1.0/origin_ui
to/api/v1.0/auth/
, the origin UI code is updated to the correct URLsserver-web-activation-code
andserver-web-passwd
respectively./health
API behind the authentication middlewareTesting Instructions
director
registry
andorigin
https://localhost:8444/view
and ensure you can visit origin's web ui as beforeorigin-ui-passwd
under your/etc/pelican
directory/etc/pelican
now you should see aserver-web-passwd