Run release action against triggering tag instead of checking out branch #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the action would trigger on a tag like `v7.12.3` and would then use regex to checkout `v7.12.x`, which it would use for generating goreleaser artifacts. If I'm parsing things correctly, this means that creating a tag and then adding extra commits on top of 7.12.x _could_ cause us to build the wrong thing. Instead, this just checks out whatever github ref triggered the action and builds that.
jhiemstrawisc
added
bug
Saartank
approved these changes
Jan 7, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the action would trigger on a tag like
v7.12.3and would then use regex to checkoutv7.12.x, which it would use for generating goreleaser artifacts.If I'm parsing things correctly, this means that creating a tag and then adding extra commits on top of 7.12.x could cause us to build the wrong thing if the tag is pushed after the extra commits.
Instead, this just checks out whatever github ref triggered the action and builds that.